Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Added test for tricontour in test_datetime.py#27494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for finding this.
It is actually the the goal of doing this exercise tofind the places where we think we should support unitful behavior but do not.
It appears that actually currentmain does noterror but also doesn't behave correctly either when handed (at least numpy datetime64 arrays) datetimes. I've opened#27499 to track this problem (along with the othertri* methods)
I will block merging this until the underlying problems are addressed.
| def test_tricontourf(self): | ||
| fig, ax = plt.subplots() | ||
| ax.tricontourf(...) | ||
| def test_tricontour(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It looks like you wrote the test fortricontour (the unfilled variant), but deleted the stub fortricontourf (the filled variant)
Uh oh!
There was an error while loading.Please reload this page.
PR summary
This PR addresses the tricontour task in the Increase Unit Test Coverage Issue:#26864.
PR checklist