Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adding test for axes.streamplot using datetime#27489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jhimanish wants to merge1 commit intomatplotlib:main
base:main
Choose a base branch
Loading
fromjhimanish:test/streamplot

Conversation

jhimanish
Copy link

@jhimanishjhimanish commentedDec 10, 2023
edited
Loading

PR summary

I've created a test for Axes.streamplot in test_datetime.py as requested in#26864
I tried using the normal datetime.datetime data type and passing that into np.meshgrid. However, it looks like np.meshgrid doesn't accept the datetime type and only accepts numerical arrays. I tried doing some research and looking into np.meshgrid further but could not find any way to pass in an array of datetime values. Therefore, I had to convert the datetime values into numerical values using date2num. This allows it to be passed into np.meshgrid to create the X and Y arrays which are then passed into the streamplot function.

Note: I am new to working with matplotlib and also new to open-source contributions so I would really appreciate your support and advice on this PR.

The outputted graph is as follows:
image

PR checklist

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Copy link
Member

@ksundenksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for finding this.

It is actually the the goal of doing this exercise tofind the places where we think we should support unitful behavior but do not.

I have opened#27500 to track the underlying problem.

I will block merging this until the underlying problems are addressed.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@ksundenksundenksunden requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@jhimanish@ksunden@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp