Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add Axes.violinplot datetime test#27485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

tanvincible
Copy link

PR summary

Add complementary test for axes.violinplot in Matplotlib
This is modeled forAxes.violinplot in#26864

Image of generated plot:

Figure 2023-12-09 174127

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@jklymak
Copy link
Member

Your commit has erased all the other tests. Suggest you copy and paste your test somewhere, do a hard rebase on upstream/main and try again.

tanvincible reacted with thumbs up emoji

@ksundenksunden mentioned this pull requestDec 11, 2023
64 tasks
@ksunden
Copy link
Member

Further, this shows thatviolinplotdoes not participate in the units system currently (for the main axis, I think it would be fine with doingpositions in dates, which perhaps we should test regardless).

And arguably, it shouldn't?

We have a similar problem in#27038 (boxplots) because these statistical measures don't really translate well to dates.

OTOH, I think itcould translate well to physical units, so perhaps weshould make it so that at least wetry to adhere to the units behavior...

I could make an argument for doing the unit conversion and doing the KDE/stats on the resultant floats (not sure I love that, though formost things I think it should be fine... its really nonlinear units that we'd have to worry about there...)

All that said, I am now curious if at least the positioning values (position andwidth) work as desired (with the latter being atimedelta). Because while doing statistics on dates can get strange fast (not impossible, just have to be careful about knowing what you are doing), saying "I want a violin plot comparing measurements taken on different dates" seemscompletely reasonable.

I think my leaning is to deprioritize fixing of units along the stats axis of these, but ask that this test case is written to focus onpositions instead for the time being.

Copy link
Member

@QuLogicQuLogic left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is no longer a test, so cannot be merged as is (regardless of the other concerns above.)

@tanvincibletanvincibleforce-pushed themtanvi19-add-violinplot-datetime-test branch from7926923 to60d2f95CompareDecember 13, 2023 11:38
@tanvincibletanvincible deleted the mtanvi19-add-violinplot-datetime-test branchDecember 13, 2023 15:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@QuLogicQuLogicQuLogic requested changes

Assignees
No one assigned
Projects
Status: Waiting for author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@tanvincible@jklymak@ksunden@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp