Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix test visualization tool for non-PNG files#27470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
For non-PNG files, our test diffing code creates a failed diff with asuffix of `_{ext}-failed-diff.png`, but the expected image has a suffixof `-expected_{ext}.png`. The test visualization was not correctlyhandling this difference.uh how do we see these diffs? |
You have to run |
5 tasks
Member
story645 commentedDec 8, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks#27471 😄 |
story645 approved these changesDec 8, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR summary
For non-PNG files, our test diffing code creates a failed diff with a suffix of
_{ext}-failed-diff.png, but the expected image has a suffix of-expected_{ext}.png. The test visualization was not correctly handling this difference by trimming filenames the same way for each case, resulting the expected/actual/diff images being split into non-existent test names.Also, make the resulting file HTML5 compliant.
PR checklist