Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Add test_eventplot to test_datetime.py#27466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
On a side note, you should probablyset your email address in your git config. The first commit is using a random DHCP-supplied hostname from NYU, and the second is using your default macbook hostname.
Uh oh!
There was an error while loading.Please reload this page.
I think we may wish to add a testcase which exercise the units behavior on the While I think the test cases here are perfectly good for the more ordinary use of eventplot, checking that those do the sensible thing is part of what we want. |
I'm able to use |
I've opened#27479 to track this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sincelinelengths is not well supported (and we have an issue to track getting it supported) I'll go ahead and approve this for what it is. We can edit it to includelinelengths as timedeltas when that has been addressed.
Thanks@shriyakalakata! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
Uh oh!
There was an error while loading.Please reload this page.
PR summary
I have added a datetime smoke test/example code under the test_eventplot method in lib/matplotlib/test/test_datetime.py. This addresses the Axes.eventplot task from#26864.
(edited) The plots generated from the latest test code:
PR checklist