Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fixing Issue #21879 Changed int to round in backend_agg.py#27465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please purge the virtual enviromnent from the checkin.
oliviavanzandt commentedDec 8, 2023
@tacaswell How do you purge the virtual environment from the checkin? |
Hello just following up, ran rm -r for my development environment. The folder no longer shows up on my local, but I is still showing in my pull request? Let me know if you have encountered this situation before. Thank you very much. |
I think you needed |
PR summary
This Pull Request attempts to fix the issue described in issue#21879. There was a rounding bug, and we changed the int casting into round instead. This should solve the rounding bug and improve functionality of matplotlib.
#21879