Attempted to add code totest_pcolorfast intest_datetime.py as requested in#26864
Based on my researches and shallow understandings of the code, the original functionpcolorfast() does not seem to directly support inputs of typedatetime.datetime ornumpy.datetime64; therefore I have useddate2num() to make the graph print correctly.
I am (almost) new to GitHub and entirely new to OSS contributions so I apologize ahead if I have made mistakes or caused trouble. Please feel free to point out my flaws and mistakes so that I can correct them.

The outputted graph is as follows:

PR checklist

"closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
Plotting related features are demonstrated in anexample
[N/A]New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

AndyXi163 added3 commits

December 6, 2023 01:51

Attempted to add test_pcolorfast in test_datetime.py

b32b386

Removed placeholder.

b2e12e9

Fixed formatting.

3966ad4

github-actionsbot reviewed

Dec 6, 2023

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

AndyXi163 closed this

Dec 6, 2023

AndyXi163 reopened this

Dec 6, 2023

AndyXi163 marked this pull request as ready for review

December 6, 2023 07:15

Copy link

Author

AndyXi163 commentedDec 6, 2023

Wait... what's happening with all the test fails...?
I will be very grateful if someone can briefly explain it for me; thanks!

ksunden requested changes

Dec 6, 2023

View reviewed changes

lib/matplotlib/tests/test_datetime.py OutdatedShow resolvedHide resolved

Copy link

Member

ksunden commentedDec 6, 2023

Thank you for working this!

One of the explicit goals of writing these tests was in fact tofind places where our unit handling could be better/methods thatshould participate in unit conversions but don't. Could you create an issue to help us track it?

We may not merge this PR before that is resolved, since actually passingdatetimes in is intended to work and is what we wish to be testing here (though I don't think we shouldremove the test as not wanted because we will want it eventually.)