Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Add test_quiverkey to test_datetimes.py#27448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
I do not think this is actually exercising the units machinery that is the goal of these tests (and don't really think it has any real way to test it) While it is using datetimes for the x values, that is part of the Thus I think the course of action is to remove this test. |
Yeah, looking at it again I agree. This isn't that applicable to datetime. I'll close this PR and make a new one to remove |
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Added datetime smoke test for
Axes.quiverkey. Proves that a quiverkey label can have a datetime assigned to itThis is one of the tests tasked by#26864
PR checklist