Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added default kwargs values to figure.suptitle() in rcParams and inheritance for function#27436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
ngmatt882 wants to merge7 commits intomatplotlib:main
base:main
Choose a base branch
Loading
fromngmatt882:rcParams

Conversation

ngmatt882
Copy link

@ngmatt882ngmatt882 commentedDec 4, 2023
edited
Loading

PR summary

This PR addresses issue#24090 which requests to added default kwargs parameters to use for function figure.suptitle() in rcParams. Basic default parameters have been added and adapted to use in inheritance. PR needs to be reviewed and cancloses#24090.

PR checklist

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@oscargus
Copy link
Member

Thanks for this!

Some quick notes:

It seems like to naming is inconsistent in the files. For example:figure.title_locy,figure.titleloc_y, andfigure.title_y are all used for what I believe is the same parameter. I think there needs to be some discussion about the "best" name. (Personally, I thinkfigure.title.y, but since there is, e.g.,figure.titlesize already, it doesn't really make sense to change format.)

This will also need a "What's new"-note.

@ngmatt882
Copy link
Author

Thanks for catching that. I settled for title_x and title_y as a good mix of both naming formats.

@ksunden
Copy link
Member

there is still a mix oftitle_ha andtitleha, causing CI to fail

ngmatt882 reacted with thumbs up emoji

@@ -331,8 +331,9 @@ def _suplabels(self, t, info, **kwargs):
@_docstring.copy(_suplabels)
def suptitle(self, t, **kwargs):
# docstring from _suplabels...
info = {'name': '_suptitle', 'x0': 0.5, 'y0': 0.98,
'ha': 'center', 'va': 'top', 'rotation': 0,
info = {'name': '_suptitle', 'x0': 'figure.title_x',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I do not understand howx0 andy0 get turn from the rcParam names into actual values?

My guess is that this is related to the failures in the doc build

@tacaswelltacaswell added this to thev3.9.0 milestoneDec 7, 2023
@QuLogicQuLogic modified the milestones:v3.9.0,v3.10.0Mar 15, 2024
@tacaswelltacaswell marked this pull request as draftSeptember 18, 2024 21:16
@tacaswell
Copy link
Member

This needs a reabase and we think there is still a missing part of the implementation where we actually use the new rcparams.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell left review comments

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Projects
Status: Waiting for author
Milestone
future releases
Development

Successfully merging this pull request may close these issues.

[ENH]: Add default kwargs values if figure.suptitle(t, **kwargs) to rcParams and inherit from there.
5 participants
@ngmatt882@oscargus@ksunden@tacaswell@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp