Movatterモバイル変換

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

KheshavKumar added2 commits

December 3, 2023 15:45

Added test for Axes.bar_label after fixing typos

37f3603

Added test for Axes.bar_label after fixing typos

bc9910a

jklymak reviewed

Dec 3, 2023

lib/matplotlib/tests/test_datetime.py OutdatedShow resolvedHide resolved

jklymak reviewed

Dec 3, 2023

lib/matplotlib/tests/test_datetime.py OutdatedShow resolvedHide resolved

KheshavKumarand others added2 commits

December 3, 2023 19:55

Updated code based on review

0c7e5f8

Update test_datetime.py

2719ef4

jklymak approved these changes

Dec 4, 2023

Copy link

Member

jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me. Thanks!

jklymak requested changes

Dec 4, 2023

Copy link

Member

jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ooops, approved too quickly. This no longer hasbar_label! Though likely a fine test forax.bar if there isn't one already.

Copy link

Member

ksunden commentedDec 4, 2023

#27033 is a test forbar, which also exercises e.g. thewidth andbottom args.

I think you can just add back thebar_label call and be good... I could see an argument for testing dates on each of the axes, but not so concerned withbar_label compared to a lot of methods, so we can start with just the simple case, I think.

ksunden reviewed

Dec 4, 2023

[TST]: increase unit test coverage#26864

lib/matplotlib/tests/test_datetime.py OutdatedShow resolvedHide resolved

QuLogic mentioned this pull request

Dec 5, 2023

Open

64 tasks

KheshavKumar added3 commits

December 4, 2023 20:32

removed the .show line and added bar_label back

e2f416d

added bar_label, removed show

e382523

added bar_label, removed show, fixed linting issues

dfd1ee8

Copy link

ContributorAuthor

KheshavKumar commentedDec 5, 2023

Apologies for the mistake! I added back a line with the bar_label function let me know how it looks now/ if there is anything else I should change

jklymak approved these changes

Dec 5, 2023

QuLogic reviewed

Dec 5, 2023

lib/matplotlib/tests/test_datetime.py OutdatedShow resolvedHide resolved

Update lib/matplotlib/tests/test_datetime.py

1d5630e

Changed axs to axCo-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

QuLogic approved these changes

QuLogic added topic: testing topic: date handling labels

QuLogic added this to thev3.9.0 milestone

QuLogic merged commit302fd39 intomatplotlib:main

Copy link

Member

QuLogic commentedDec 7, 2023

Thanks@KheshavKumar! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

bikegeek added a commit to bikegeek/matplotlib that referenced this pull request

Added test for Axes.hexbin (matplotlib#27431)

1964eab

bikegeek added a commit to bikegeek/matplotlib that referenced this pull request

Added test for Axes.hexbin (matplotlib#27431)

6d5038f

bikegeek added a commit to bikegeek/matplotlib that referenced this pull request

Added test for Axes.hexbin (matplotlib#27431), with additional plots.

c6cae1b

bikegeek added a commit to bikegeek/matplotlib that referenced this pull request