NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Added test for broken_barh to test_datetime.py#27428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

QuLogic merged 1 commit intomatplotlib:mainfromavramid9:test_broken_barh

Dec 5, 2023

Merged

Added test for broken_barh to test_datetime.py#27428

QuLogic merged 1 commit intomatplotlib:mainfromavramid9:test_broken_barh

Dec 5, 2023

Conversation

Copy link

Contributor

avramid9 commentedDec 3, 2023

PR summary

Added code fortest_broken_barh intest_datetime.py as requested in#26864

Here is an image of the output:

PR checklist

[N/A] "closes #0000" is in the body of the PR description tolink the related issue
[N/A] new and changed code istested
[N/A]Plotting related features are demonstrated in anexample
[N/A]New Features andAPI Changes are noted with adirective and release note
[N/A] Documentation complies withgeneral anddocstring guidelines

github-actionsbot reviewed

Dec 3, 2023

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

oscargus mentioned this pull request

Dec 4, 2023

[TST]: increase unit test coverage#26864

Open

64 tasks

Copy link

Member

oscargus commentedDec 4, 2023

Thank you! I think it makes sense to remove the labels and the caption though (as that will test unrelated things).

oscargus added the topic: testing label

Dec 4, 2023

Added test for broken_barh to test_datetime.py

cad6d11

avramid9 force-pushed thetest_broken_barh branch from2683e70 tocad6d11Compare

December 5, 2023 19:11

Copy link

ContributorAuthor

avramid9 commentedDec 5, 2023

I have removed all labels and titles as per@oscargus request. I noticed that there are some failing tests on my branch that seem to be fortest_pylab_integration. I am not 100% sure but I don't think this would be caused by the test that I added. Are these known to have flaky behavior?

ksunden approved these changes

Dec 5, 2023

View reviewed changes

Copy link

Member

ksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't see any reason this would be connected to that failed test, though I've not known that to be a flaky test in the past... I'll rerun those tests to be sure, but everything looks fine here, AFAIK