Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added Axes.stairs test in test_datetime.py#27424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ifEricReturnTrue
Copy link
Contributor

@ifEricReturnTrueifEricReturnTrue commentedDec 2, 2023
edited
Loading

PR summary

add code for Axes.stairs in test_datetime.py as requested in#26864.
image

PR checklist

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@oscargusoscargus mentioned this pull requestDec 4, 2023
64 tasks
@oscargus
Copy link
Member

Thank you! I'd suggest using dates for more than just the x-axis (currently, the three subplots are testing the same thing). A common pattern is something like:

  • dates for x-axis
  • dates for y-axis
  • dates for both x- and y-axis

In this way, one can be a bit more certain that it works.

@ifEricReturnTrue
Copy link
ContributorAuthor

Hi!
I have changed my test as you requested. Please see the updated plot below. Thanks!
image

@ksunden
Copy link
Member

I think that an explicit value should be passed forbaseline here. the default value is the (arbitrary) zero mark for our date system (1980-01-01), and that is creeping into these plots.

That also tests that the baseline behavior acts as we expect with unitful data.

@ifEricReturnTrue
Copy link
ContributorAuthor

Hi! Thank you for your reply. I tried to use baseline but I found there is no where else using this baseline value in the test_datetime file. Is it necessary to use this value in this test?

@ksunden
Copy link
Member

baseline is a parameter specifically tostairs. thebottom argument tobar andstem is the same idea (just a different name).

(stackplot also had discussion aboutbaseline, though that spun out into#27129, because that method only supports specific values)

@ifEricReturnTrue
Copy link
ContributorAuthor

Thank you for the clarification! I have added the baseline component into my test in the latest commits. And you can see that the figure is now limited at 1980-1-1
image

@ksundenksunden added this to thev3.9.0 milestoneDec 11, 2023
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@ifEricReturnTrue
Copy link
ContributorAuthor

Thank you for your suggestion! I have just committed your suggestions!

@QuLogicQuLogic changed the titleCompleted Axes.stairs in test_datetime.pyAdded Axes.stairs test in test_datetime.pyDec 13, 2023
@QuLogicQuLogic merged commit1c6fb79 intomatplotlib:mainDec 13, 2023
@QuLogic
Copy link
Member

Thanks@ifEricReturnTrue! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@QuLogicQuLogicQuLogic approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

4 participants
@ifEricReturnTrue@oscargus@ksunden@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp