NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Add test for fill_between in test_datetime.py#27423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

oscargus merged 5 commits intomatplotlib:mainfromlinyilily:unit-test-lily

Dec 5, 2023

Merged

Add test for fill_between in test_datetime.py#27423

oscargus merged 5 commits intomatplotlib:mainfromlinyilily:unit-test-lily

Dec 5, 2023

Conversation

Copy link

Contributor

linyilily commentedDec 2, 2023•
edited
Loading

PR summary

add code for test_fill_between in test_datetime.py as requested in#26864.

Output image:

PR checklist

resolves part of [TST]: increase unit test coverage #26864
new and changed code istested
Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

Linyi Li added2 commits

December 2, 2023 14:54

add test for fill_between in test_datetime.py

a4abcce

fix error in checks

aa4a096

Copy link

ContributorAuthor

linyilily commentedDec 2, 2023

this pull request resolves part of#26864

github-actionsbot reviewed

Dec 2, 2023

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

make y values always increasing

608776b

jklymak approved these changes

Dec 3, 2023

View reviewed changes

oscargus added the topic: testing label

Dec 4, 2023

Copy link

Member

oscargus commentedDec 4, 2023

I believe that the second subplot can be removed since it is not related to dates (plain floats, which should be tested elsewhere). Otherwise makes sense.