Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
TST: Cache available interactive backends#27422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There are currently 7 backends, and this function is called 8 timesduring test collection. This means that `XOpenDisplay` would be called56 times (multiplied by process count if using xdist).Locally, I'm seeing a deadlock after too many calls to `XOpenDisplay`during collection. While this is not directly our bug, it seems prudentto cut this down to only the one check per collection process.I don't think we can cache this globally, as one might want to re-try aGUI figure after starting an X server (e.g., over SSH or similar),without restarting Python/Matplotlib.
timhoffm approved these changesDec 2, 2023
This fixes the collection failure for me as well. |
Closed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
There are currently 7 backends, and this function is called 8 times during test collection. This means that
XOpenDisplaywould be called 56 times (multiplied by process count if using xdist).Locally, I'm seeing a deadlock after too many calls to
XOpenDisplayduring collection. While this is not directly our bug, it seems prudent to cut this down to only the one check per collection process.I don't think we can cache this globally, as one might want to re-try a GUI figure after starting an X server (e.g., over SSH or similar), without restarting Python/Matplotlib.
PR checklist