Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Switch pytest fixture from tmpdir to tmp_path#27417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
story645 merged 1 commit intomatplotlib:mainfromtimhoffm:tmp_path
Dec 1, 2023

Conversation

timhoffm
Copy link
Member

tmp_path is the more modern version providing standard pathlib.Path objects and preferred nowadayshttps://docs.pytest.org/en/7 .4.x/reference/reference.html#tmpdir.

Copy link
Member

@oscargusoscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Subject to getting rid of the unused imports.

tmp_path is the more modern version providing standardpathlib.Path objects and preferred nowadayshttps://docs.pytest.org/en/7.4.x/reference/reference.html#tmpdir.
@timhoffm
Copy link
MemberAuthor

Done. I should definitively set up precommit.

@oscargus
Copy link
Member

Yeah, pre-commit is pretty nice once it works!

Anyone can merge on green.

@story645
Copy link
Member

story645 commentedDec 1, 2023
edited
Loading

do we want this backported for later PRs writing against this code or let the backporting happen as part of backporting those prs?

@timhoffmtimhoffm added this to thev3.9.0 milestoneDec 1, 2023
@timhoffm
Copy link
MemberAuthor

I would not backport. The likelihood of backporting changes to tests is quite small.

@story645story645 merged commitac74b74 intomatplotlib:mainDec 1, 2023
@timhoffmtimhoffm deleted the tmp_path branchDecember 4, 2023 01:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@story645story645story645 approved these changes

@oscargusoscargusoscargus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

3 participants
@timhoffm@oscargus@story645

[8]ページ先頭

©2009-2025 Movatter.jp