Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Switch pytest fixture from tmpdir to tmp_path#27417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Subject to getting rid of the unused imports.
tmp_path is the more modern version providing standardpathlib.Path objects and preferred nowadayshttps://docs.pytest.org/en/7.4.x/reference/reference.html#tmpdir.
Done. I should definitively set up precommit. |
Yeah, pre-commit is pretty nice once it works! Anyone can merge on green. |
story645 commentedDec 1, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
do we want this backported for later PRs writing against this code or let the backporting happen as part of backporting those prs? |
I would not backport. The likelihood of backporting changes to tests is quite small. |
tmp_path is the more modern version providing standard pathlib.Path objects and preferred nowadayshttps://docs.pytest.org/en/7 .4.x/reference/reference.html#tmpdir.