I have added a datetime smoke test forAxes.vlines inlib/matplotlib/tests/test_datetime.py. It includes a combination of dates and floats for the axes as well as scalars and arrays for ymin and ymax.
This addresses theAxes.vlines task from#26864.

Here is an image of the plots:

PR checklist

[N/A] "closes #0000" is in the body of the PR description tolink the related issue
[N/A] new and changed code istested
[N/A]Plotting related features are demonstrated in anexample
[N/A]New Features andAPI Changes are noted with adirective and release note
[N/A] Documentation complies withgeneral anddocstring guidelines

github-actionsbot reviewed

Nov 30, 2023

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

madisonwong210 force-pushed thetest_vlines branch 2 times, most recently frome5b99f1 to00c8072Compare

December 1, 2023 01:07

QuLogic reviewed

Dec 1, 2023

View reviewed changes

lib/matplotlib/tests/test_datetime.py OutdatedShow resolvedHide resolved

madisonwong210 force-pushed thetest_vlines branch 3 times, most recently froma2252b7 toc543e4fCompare

December 2, 2023 03:16

QuLogic reviewed

Dec 2, 2023

View reviewed changes

lib/matplotlib/tests/test_datetime.py

		ymax=[np.datetime64('2023-05-01'), np.datetime64('2023-05-16')])
		ax3.set_xlim(left=datetime.datetime(2023, 7, 1),
		right=datetime.datetime(2023, 12, 31))
		ax3.vlines(x=[datetime.datetime(2023, 9, 1), datetime.datetime(2023, 12, 10)],

Copy link

Member

QuLogicDec 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Any reason not to re-usedates on this one?

Copy link

ContributorAuthor

madisonwong210Dec 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wanted to make each graph look fairly different from one other, so I tried to pick different dates and x/y limits. Initially, thedates array was too long to fit on one line which is why I made it a separate variable. If you'd prefer I re-use it, I can make the change but would have to modify the x limit as well because the values indates fall outside of the current range for ax3. Let me know what you think

Copy link

ContributorAuthor

madisonwong210Dec 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Alternatively, I could get rid ofdates altogether and move the array directly intoax1.vlines() but keep each element on a different line like it is right now