Nov 30, 2023 · Nov 30, 2023 · Dec 2, 2023 · Dec 2, 2023 · Dec 2, 2023 · Dec 4, 2023
diff --git a/lib/matplotlib/tests/test_datetime.py b/lib/matplotlib/tests/test_datetime.py
        ax2.plot_date(x_dates, y_ranges)
        ax3.plot_date(x_ranges, y_dates)

    @pytest.mark.xfail(reason="Test for quiver not written yet")
    @mpl.style.context("default")
    def test_quiver(self):
        fig, ax = plt.subplots()
        ax.quiver(...)
        dates = [datetime.datetime(2023, 1, 1) + datetime.timedelta(days=i)
                 for i in range(5)]
        x = dates
        y = np.zeros_like(x, dtype=float)
        u = np.sin(np.arange(len(x)))
        v = np.cos(np.arange(len(x)))
        fig, ax = plt.subplots(figsize=(10, 6))
        ax.quiver(x, y, u, v, scale=20)
        fig.autofmt_xdate()
        ax.set_title('Quiver Plot with Datetime Data')
        ax.set_xlabel('Date')
        ax.set_ylabel('Y-axis')

    @pytest.mark.xfail(reason="Test for quiverkey not written yet")
    @mpl.style.context("default")
Original file line number	Diff line number	Diff line change
Expand Up		@@ -446,11 +446,20 @@ def test_plot_date(self):
		ax2.plot_date(x_dates, y_ranges)
		ax3.plot_date(x_ranges, y_dates)

		@pytest.mark.xfail(reason="Test for quiver not written yet")
		@mpl.style.context("default")
		def test_quiver(self):
		fig, ax = plt.subplots()
		ax.quiver(...)
		dates = [datetime.datetime(2023, 1, 1) + datetime.timedelta(days=i)
		for i in range(5)]
		x = dates
		y = np.zeros_like(x, dtype=float)
		u = np.sin(np.arange(len(x)))
		v = np.cos(np.arange(len(x)))
		fig, ax = plt.subplots(figsize=(10, 6))
		ax.quiver(x, y, u, v, scale=20)
Copy link Member QuLogicDec 2, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. It seems like`y` could also be tested? I'm not sure if it also makes sense to try`u` and`v` as well. Copy link ContributorAuthor rawwashDec 2, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Quiver plots typically expect numerical values for u and v (representing vector components), and y is usually a numerical position value. Using datetime objects for these variables would be unconventional and might not work directly with the quiver plot functionality. I think it might be better to maintain the test as is. Copy link Member QuLogicDec 4, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I don't really follow the assertion that`y` is usually a numerical position value. But in any case, these tests are to check whether the code works, not what the "usual" type is. We absolutely want to test things that are unusual. Copy link Member ksundenDec 5, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I agree that y is not actually different from x here and should be tested, additionally Ido think u/v should be tested with`angles="xy"` and u/v supplied as`timedelta`s. I think passing u/v as timedeltas shouldnot be included with the (default)`angles="uv"`
		fig.autofmt_xdate()
		ax.set_title('Quiver Plot with Datetime Data')
		ax.set_xlabel('Date')
		ax.set_ylabel('Y-axis')

		@pytest.mark.xfail(reason="Test for quiverkey not written yet")
		@mpl.style.context("default")
Expand Down