NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Add test_fill in test_datetime.py#27401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

QuLogic merged 4 commits intomatplotlib:mainfromnidaa-7:test_fill

Dec 2, 2023

Merged

Add test_fill in test_datetime.py#27401

QuLogic merged 4 commits intomatplotlib:mainfromnidaa-7:test_fill

Dec 2, 2023

Conversation

Copy link

Contributor

nidaa-7 commentedNov 30, 2023•
edited by ksunden
Loading

PR summary

Added code fortest_fill intest_datetime.py as requested in#26864

Image of an output:

PR checklist

resolves part of[TST]: increase unit test coverage #26864
new and changed code istested
Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

nidaa-7 added3 commits

November 29, 2023 08:35

added a test for fill in test_datetime.py

40e8132

Removed saving the picture from test code.

7de0d46

reverted .gitignore changes

6157b1f

I had added my virtual environment to gitignore and pushed it. Reverted back before pull request

github-actionsbot reviewed

Nov 30, 2023

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

QuLogic reviewed

Nov 30, 2023

View reviewed changes

lib/matplotlib/tests/test_datetime.pyShow resolvedHide resolved

added seed

b553dab

ksunden approved these changes

Nov 30, 2023

View reviewed changes

Copy link

Member

ksunden commentedNov 30, 2023

(Edited the description just to prevent autoclosing of#26864, since this does not complete the whole of that issue, just one task (which is how that issue is designed))