Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC: Moved dependencies under install because they're version dependent#27395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:mainfromstory645:dependencies-install
Dec 7, 2023

Conversation

story645
Copy link
Member

@story645story645 commentedNov 29, 2023•
edited
Loading

PR summary

Based on discussion in#27386 and#22866, it seems consensus is towards the documents under/devel being version independent. Since the dependencies are tracked to the version, I moved thedependencies document from/devel tousers/installing/ and updated the cross references. ETA: this move is specifically intended so thatdependencies.html does not get caught in a bulk redirect to the development version.

Changes

  • /devel/dependencies ->/users/installing/dependencies
  • changed heading levels so that install FAQ and Troubleshooting are sections of the installation document
  • removed dependencies from/devel/index because its explicitly listed as a step in development_setup
  • removed environment_variables from/devel/index and add a link in thebuild options section ofinstallation because thats where we mention the other environment variables
  • made environment_variables more prominent under install

My preference would be to move/installing out of/users and make it a top level folder, sodoc/install now that/doc is the root documentation folder, but that's out of scope here.

PR checklist

@story645story645 added Documentation: devdocsfiles in doc/devel Documentation: user guidefiles in galleries/users_explain or doc/users labelsNov 29, 2023
@story645story645force-pushed thedependencies-install branch 2 times, most recently from0713d4a tob6ab6d9CompareNovember 29, 2023 19:35
@story645story645force-pushed thedependencies-install branch 4 times, most recently from8a616f4 to9535ca6CompareNovember 29, 2023 21:13
@story645
Copy link
MemberAuthor

So I think moving this out to install is an improvement b/c it is part of the general installation process and it helps with scoping '/devel' to docs where only the latest version matters - regardless of whether we end up w/ a bulk redirect or extracting out or just rewriting some links.

@QuLogicQuLogic changed the titleDOC: Moved dependencies under install because its version dependentDOC: Moved dependencies under install because they're version dependentDec 4, 2023
@tacaswelltacaswell merged commitd267a1d intomatplotlib:mainDec 7, 2023
@QuLogicQuLogic added this to thev3.9.0 milestoneDec 7, 2023
@story645story645 deleted the dependencies-install branchDecember 7, 2023 20:46
@story645
Copy link
MemberAuthor

@QuLogic doesn't this need to be backported to stable if stable gets redirected?

@QuLogicQuLogic modified the milestones:v3.9.0,v3.8-docDec 7, 2023
@QuLogic
Copy link
Member

Yes, if you want it published to stable, it'll need to be backported. And@ksunden will have to rebuild and push.

@meeseeksdev backport to v3.8.x
@meeseeksdev backport to v3.8.2-doc

@lumberbot-appLumberbot (App)
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.8.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 d267a1d353ba09300a16621364670ec7ebba0fb9
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am "Backport PR #27395: DOC: Moved dependencies under install because they're version dependent"
  1. Push to a named branch:
git push YOURFORK v3.8.x:auto-backport-of-pr-27395-on-v3.8.x
  1. Create a PR against branch v3.8.x, I would have named this PR:

"Backport PR#27395 on branch v3.8.x (DOC: Moved dependencies under install because they're version dependent)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@lumberbot-appLumberbot (App)
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.8.2-docgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 d267a1d353ba09300a16621364670ec7ebba0fb9
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am "Backport PR #27395: DOC: Moved dependencies under install because they're version dependent"
  1. Push to a named branch:
git push YOURFORK v3.8.2-doc:auto-backport-of-pr-27395-on-v3.8.2-doc
  1. Create a PR against branch v3.8.2-doc, I would have named this PR:

"Backport PR#27395 on branch v3.8.2-doc (DOC: Moved dependencies under install because they're version dependent)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

story645 pushed a commit to story645/matplotlib that referenced this pull requestDec 8, 2023
DOC: Moved dependencies under install because they're version dependent(cherry picked from commitd267a1d)
story645 pushed a commit to story645/matplotlib that referenced this pull requestDec 8, 2023
DOC: Moved dependencies under install because they're version dependent(cherry picked from commitd267a1d)
story645 pushed a commit to story645/matplotlib that referenced this pull requestDec 8, 2023
DOC: Moved dependencies under install because they're version dependent(cherry picked from commitd267a1d)
QuLogic added a commit that referenced this pull requestDec 8, 2023
QuLogic added a commit that referenced this pull requestDec 8, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Labels
Documentation: devdocsfiles in doc/develDocumentation: user guidefiles in galleries/users_explain or doc/users
Projects
None yet
Milestone
v3.8-doc
Development

Successfully merging this pull request may close these issues.

3 participants
@story645@QuLogic@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp