Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove test_spy from test_datetime.py#27392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 4 commits intomatplotlib:mainfromrawwash:test_spy
Dec 1, 2023

Conversation

rawwash
Copy link
Contributor

@rawwashrawwash commentedNov 29, 2023•
edited
Loading

PR summary

Removing the test_spy for datetime, since does not make sense for unitful data. Spy is related to plotting at array indices, and provides no way of setting the x and y values to non-integer data.

Therefore, this PR aims to remove test_spy.

PR checklist

Comment on lines 497 to 505
data = np.random.rand(10, 10)
data[data < 0.9] = 0
fig, ax = plt.subplots()
sp = ax.spy(data)
ax.set_title('Spy Plot Test')
ax.set_xlabel('Column Index')
ax.set_ylabel('Row Index')
assert sp is not None, "Failed to create spy plot"
plt.close(fig)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This does not use datetime

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Understood, I have redone it with datetime functionality.

@ksunden
Copy link
Member

I do not think thatspy makes sense for unitful data. It is explicitly about plotting at array indices, and provides no way of setting the x and y values to non-integer data.

Therefore, I think the course of action for this method in particular is to simply remove the test template

@rawwash
Copy link
ContributorAuthor

Ok, sounds good I can remove the test.

@rawwashrawwash changed the titleAdded test_spy in test_datetime.pyRemoving test_spy in test_datetime.pyNov 29, 2023
@ksundenksunden mentioned this pull requestNov 30, 2023
64 tasks
@QuLogicQuLogic changed the titleRemoving test_spy in test_datetime.pyRemove test_spy from test_datetime.pyDec 1, 2023
@QuLogicQuLogic merged commit0117642 intomatplotlib:mainDec 1, 2023
@QuLogicQuLogic added this to thev3.9.0 milestoneDec 1, 2023
@QuLogic
Copy link
Member

QuLogic commentedDec 1, 2023•
edited
Loading

Thanks@rawwash! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

Note that I squash merged this PR, as there was no need for the separate commits.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

3 participants
@rawwash@ksunden@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp