Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix build on PyPy#27359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix build on PyPy#27359
Uh oh!
There was an error while loading.Please reload this page.
Conversation
It appears that `Py_FileSystemDefaultEncodeErrors` is not part of thelimited API, and PyPy does not have it.Since pybind11 does not have a wrapper for `PyUnicode_EncodeFSDefault`(the main reason I had switched to a `encode` call earlier), we need tocall it ourselves manually.
Is this a problem only for the meson builds? |
I don't think so; I forgot to mention it was caused by#26992 according to the CI logs. |
Ahh, okay, I was wondering if it needed to be backported (and possibly prompt another release), but the line that is changing is only on main, so don't think so. |
Should we be concerned that this has no test coverage? |
That is definitely wrong; we probably lost coverage for compiled code in the move to Meson. |
Looking at thecoverage for the file directly, it's not really uncovered, but partially covered. This probably partially because we don't do coverage on non-Linux, but I'm investigating some outdated settings in the test config. |
PR summary
It appears that
Py_FileSystemDefaultEncodeErrorsis not part of the limited API, and PyPy does not have it. This broke wheel building CI only, as PyPy isn't otherwise built.Since pybind11 does not have a wrapper for
PyUnicode_EncodeFSDefault(the main reason I had switched to aencodecall earlier), we need to call it ourselves manually.PR checklist