Current test failures are due to minor pixel differences in the contours unrelated to this change, will keep tweaking until it passes.

TODO:

• Fix marginal test failures
• Check to see if this fixesmplot3d failed to clip bar charts if zlim is set. #8902
• [n/a] Does it make more sense for patches on the boundary to just drop a vertex instead of the entire patch? -> defer to a new issue
• Make a gallery example

Not being able to show partial lines or patches such that they are "smoothly" cut off at the boundaries of the view box is a limitation of the current renderer.

I don't think that's the case; we can definitely clip partial lines or patches to the Axes. Unless you mean the 3D renderer?

In that case, you would have to do some magic to calculate the clipping path of the Axes3D box with the artist in flattened 2D space, and apply it withset_clip_path. I'm not sure if that is worth it or not.

Thank you for the review@QuLogic! I believe all your comments are addressed now

The docs build error is unrelated:

The version switcher "https://output.circle-artifacts.com/output/job/29bcafd2-ffe3-4f64-ba51-f8cfa5bce2b5/artifacts/0/doc/build/html/_static/switcher.json" file cannot be read due to the following error:HTTPError('404 Client Error: Not Found for url: https://output.circle-artifacts.com/output/job/29bcafd2-ffe3-4f64-ba51-f8cfa5bce2b5/artifacts/0/doc/build/html/_static/switcher.json')

I think that the docs error isn't actually generic, will investigate.

/home/circleci/project/lib/mpl_toolkits/mplot3d/art3d.py:docstring of matplotlib.artist.Poly3DCollection.set:45: WARNING: py:meth reference target not found: matplotlib.collections._CollectionWithSizes.set_sizes [ref.meth]

The missing reference handler is now a bit more specific about these things, so if you've added/removed some lines in a docstring, you may have to update the line numbers in the json file to get it to skip again.

This is a rather confusing error. It traces back to./doc/missing-references.json, which has the below section:

... butset_sizes is not in theart3d.py.Poly3DCollection docstrings so I'm not sure how to adjust the numbering. Any pointers?

I did add 3 lines to the__init__() docstring, so will try adding 3 to each of these lines.

   "lib/mpl_toolkits/mplot3d/art3d.py:docstring of matplotlib.artist.Path3DCollection.set:46",    "lib/mpl_toolkits/mplot3d/art3d.py:docstring of matplotlib.artist.Poly3DCollection.set:44"

It's not complaining aboutPoly3DCollection.__init__, butPoly3DCollection.set, which is one of the weird automatic substitutions of all possible keyword arguments, but I'm not sure which one changed. It's probably easiest to build locally withmissing_references_write_json = True and see what lines changed.

Also, I just noticed this looking at other arguments, butaxlim_clip should probably get a.. versionadded:: directive in its docs.

@QuLogic I'm not seeing this error on local docs builds. Do you know of another way to track it down?

Ok, fixed the issue withWARNING: py:meth reference target not found! For future reference, I deleted the two lines in./doc/missing-references.json, pushed and waited for CI to throw the build error, and then re-added the lines with the errored line numbers.

The remaining docs error is an instance of#28744 and is unrelated.

@QuLogic I also added in.. versionadded:: 3.10 everywhere applicable, think this is good to go now.

Thank you for addressing this issue!

Which version of matplotlib will incorporate the fix? My current version is 3.9.2.

Hi@nbfazel, this will be out in the future 3.10 release.

Thank you!