Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[MNT] swap xkcd script for humor sans#27299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 1 commit intomatplotlib:mainfromstory645:remove-humorsans
Nov 17, 2023

Conversation

story645
Copy link
Member

This swaps xkcd-script for the Humor sans font b/c the way Humor sans handles the .notdef character is leading to dropped - without warning#27232
This is cherry picked out of#26854

I think we should fork a copy of the xkcd branch under matplotlib because I'm uncomfortable with relying on an unmaintained fork of an unmaintained project, but this is the most complete character set.

PR summary

PR checklist

@story645
Copy link
MemberAuthor

story645 commentedNov 9, 2023•
edited
Loading

attn@ksunden why xkcd script>xkcd
image


For best results, the "Humor Sans" font should be installed: it is
not included with Matplotlib.
For best results, install the `xkcd script <https://github.com/ipython/xkcd-font/>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This doesn't seem to be the same link as what is used for CI, and the dependencies page.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think what I should probably do is see if the plain xkcd script works & if so use that and if not PR the xkcd branch (haven't heard back from author)

@story645
Copy link
MemberAuthor

So for this PR I can get away w/ the xkcd-font on ipython since no negative ticks, but I need to fix this PR cause it's not using that font right now

@story645story645force-pushed theremove-humorsans branch 3 times, most recently frome8b9dea tobe9c90dCompareNovember 15, 2023 22:55
add xkcd-script font to doc buildCo-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com>
@story645
Copy link
MemberAuthor

story645 commentedNov 15, 2023•
edited
Loading

Ok, so docs now build w/ xckd-script font

QuLogic added a commit that referenced this pull requestNov 17, 2023
…299-on-v3.8.xBackport PR#27299 on branch v3.8.x ([MNT] swap xkcd script for humor sans)
@story645story645 deleted the remove-humorsans branchMay 2, 2024 15:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic left review comments

@oscargusoscargusoscargus left review comments

@tacaswelltacaswelltacaswell approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.8.2
Development

Successfully merging this pull request may close these issues.

5 participants
@story645@tacaswell@QuLogic@ksunden@oscargus
[8]ページ先頭
©2009-2025 Movatter.jp