Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Expand 3D import to handle any exception not just ImportError#27291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Needed for the same reasons asmatplotlib#27178 (Namely that we should not be failing on import just because mpl_toolkits is broken), but mpl 3.6 presents with an AttributeError rather than ImportErrorSee discussion inmatplotlib#26827 andmatplotlib#27289Just expanded liberally in case there are other presentations we have not seen
24a40b5 tocde6bafCompareTo be clear the mpl3.6 here is the version that is being shadowed. |
tacaswell approved these changesNov 9, 2023
oscargus approved these changesNov 9, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestNov 9, 2023
…n not just ImportError
tacaswell added a commit that referenced this pull requestNov 9, 2023
…291-on-v3.8.xBackport PR#27291 on branch v3.8.x (Expand 3D import to handle any exception not just ImportError)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for the same reasons as#27178 (Namely that we should not be failing on import just because mpl_toolkits is broken), but mpl 3.6 presents with an AttributeError rather than ImportError
See discussion in#26827 and#27289
Just expanded liberally in case there are other presentations we have not seen
PR summary
PR checklist