NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Factor out common parts of qt and macos interrupt handling.#27285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ksunden merged 1 commit intomatplotlib:mainfromanntzer:ai

Nov 15, 2023

Merged

Factor out common parts of qt and macos interrupt handling.#27285

ksunden merged 1 commit intomatplotlib:mainfromanntzer:ai

Nov 15, 2023

Conversation

Copy link

Contributor

anntzer commentedNov 7, 2023•
edited
Loading

Note that we don't actually need to disable the QSocketNotifier at the end, just letting it go out of scope should be sufficient as its destructor also does that (see qsocketnotifier.cpp in the qt source tree).

Followup to#27221.

(Also had to rename some local variables named "signal" in the CallbackRegistry implementation; otherwise the style checker complains about shadowing the imported module name... though#26013 would make some of these irrelevant.) Switched to putting the contextmanager in backend_bases.

PR summary

PR checklist

"closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

anntzer added GUI: Qt GUI: MacOSX Maintenance labels

Nov 7, 2023

anntzer added this to thev3.9.0 milestone

Nov 7, 2023

anntzer force-pushed theai branch from29de7a1 tob23b010Compare

November 7, 2023 23:13

QuLogic approved these changes

Nov 8, 2023

View reviewed changes

lib/matplotlib/cbook.py OutdatedShow resolvedHide resolved

Factor out common parts of qt and macos interrupt handling.

3bd9abe

Note that we don't actually need to disable the QSocketNotifier at theend, just letting it go out of scope should be sufficient as itsdestructor also does that (see qsocketnotifier.cpp).

anntzer force-pushed theai branch fromb23b010 to3bd9abeCompare

November 8, 2023 11:54

Copy link

ContributorAuthor

anntzer commentedNov 8, 2023

Thanks, fixed the copy editing. Also switched to putting the contextmanager in backend_bases, as that seems more specific than dumping it in cbook as a "general" utility.