Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fixes : Add setter/getter methods for all keyword parameters to Figure.__init__ #24617#27257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
layout needs added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
Thanks for taking this on! Since you're building on a previous committees work, can you please add them as a coauthorhttps://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors |
Thanks for letting me know, ill take a look and do that |
Testing addedCo-Authored by : Co-authored-by:@stanleyjs
GetSubPlot bars author added :Co-Authored by : Co-authored-by:@stanleyjs
Co author :@stanleyjs added to commits |
story645 left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think deleting everything in colorbar is what's causing many of the test failures.
Thanks for pointing that out ill look through and see if i can fix some of them |
deleted cbar in error added back
Im looking through the errors and trying to fix, but bit confused about the meaning of this one, any pointers appreciated Stub: in file lib/matplotlib/figure.pyi |
Updated with original test frommatplotlib#21549written by@stanleyjsCo-Authored-By: Jay Stanley <stanleyjs@users.noreply.github.com>
Tests should be added tohttps://github.com/matplotlib/matplotlib/blob/main/lib/matplotlib/tests/test_figure.py and not put in a new file -> I think that's why coverage thinks nothing is tested. And that error is I think cause you need to add the new setter/getter methods tohttps://github.com/matplotlib/matplotlib/blob/main/lib/matplotlib/figure.pyi seehttps://matplotlib.org/devdocs/devel/contribute.html#type-hints |
PR summary
This fixes Add setter/getter methods for all keyword parameters to Figure.init#24617
#24617
. It adds getters and setters for :
SubplotBars
Figsize
Layout .
It cherry picks code from#21549
as well as adding missing get/set for figsize
-->