NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Query macOS for available system fonts.#27230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

dstansby merged 1 commit intomatplotlib:mainfromanntzer:macosfonts

Jan 12, 2024

Merged

Query macOS for available system fonts.#27230

dstansby merged 1 commit intomatplotlib:mainfromanntzer:macosfonts

Jan 12, 2024

Conversation

Copy link

Contributor

anntzer commentedOct 30, 2023•
edited
Loading

... instead of only relying on a fixed list of directories to check. Note that both previously and with this PR, we continue also querying fontconfig.

See#10932. This should close the original issue (#10201); for#10932 I would suggest further dropping out the extra hard-coded directories (X11FontDirectories, OSXFontDirectories) that are searched.

PR summary

PR checklist

"closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

anntzer added OS: Apple topic: text/fonts labels

Oct 30, 2023

Query macOS for available system fonts.

6e3ed38

... instead of only relying on a fixed list of directories to check.Note that both previously and with this PR, we continue also queryingfontconfig.

anntzer force-pushed themacosfonts branch from87a0fe3 to6e3ed38Compare

October 30, 2023 20:47

Copy link

Member

ksunden commentedOct 30, 2023

I did not realize thatplistlib was in the std library...

QuLogic added this to thev3.9.0 milestone

Oct 31, 2023

QuLogic reviewed

Oct 31, 2023

View reviewed changes

lib/matplotlib/font_manager.py

		def _get_macos_fonts():
		"""Cache and list the font paths known to ``system_profiler SPFontsDataType``."""
		d, = plistlib.loads(
		subprocess.check_output(["system_profiler", "-xml", "SPFontsDataType"]))

Copy link

Member

QuLogicOct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is this output portable across different system languages?

Copy link

ContributorAuthor

anntzerOct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

From a quick check, the answer appears to be yes.

greglucas approved these changes

Jan 12, 2024

View reviewed changes

Copy link

Contributor

greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'll note thatsystem_profiler -xml SPFontsDataType is quite a bit slower thanfc-list for me. This does work as expected and is only adding extra time to the initial cache build.

dstansby approved these changes

Jan 12, 2024

View reviewed changes

Copy link

Member

dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM; doesn't take that long to build the font cache on this PR for me (~seconds on an M2 MacBook Air), and more fonts are found (374 before, 497 after)

dstansby merged commit18bfd1e intomatplotlib:main

Jan 12, 2024

anntzer deleted the macosfonts branch

January 12, 2024 21:07

Copy link

denis-bz commentedMay 17, 2024

@anntzer, on my macos 10.15.7 Catalina

system_profiler -xml SPFontsDataType  2>&1    # <- def _get_macos_fonts() in mpl 3.9.0

💥

2024-05-17 11:56:24.964 system_profiler[1061:15889] CoreText note: Client requested name ".AlBayanPUA", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].2024-05-17 11:56:24.964 system_profiler[1061:15889] CoreText note: Set a breakpoint on CTFontLogSystemFontNameRequest to debug.2024-05-17 11:56:24.968 system_profiler[1061:15889] CoreText note: Client requested name ".AlBayanPUA-Bold", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].2024-05-17 11:56:24.972 system_profiler[1061:15889] CoreText note: Client requested name ".AlNilePUA", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].2024-05-17 11:56:24.975 system_profiler[1061:15889] CoreText note: Client requested name ".AlNilePUA-Bold", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].2024-05-17 11:56:24.978 system_profiler[1061:15889] CoreText note: Client requested name ".AlTarikhPUA", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].2024-05-17 11:56:24.982 system_profiler[1061:15889] CoreText note: Client requested name ".AppleColorEmojiUI", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].2024-05-17 11:56:24.985 system_profiler[1061:15889] CoreText note: Client requested name ".AppleSDGothicNeoI-Regular", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].2024-05-17 11:56:24.988 system_profiler[1061:15889] CoreText note: Client requested name ".AppleSDGothicNeoI-Medium", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].2024-05-17 11:56:24.991 system_profiler[1061:15889] CoreText note: Client requested name ".AppleSDGothicNeoI-Light", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:]....

200-odd such lines.
So I reinstalled matplotlib==3.8.4.
Please advise: are there functions in font_manager.py I can call to help debug this
or caches / .jsons I can delete ? Thanks