Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add test_hlines to test_datetimes.py#27211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 4 commits intomatplotlib:mainfromCozyFrog:test_hlines
Nov 21, 2023

Conversation

CozyFrog
Copy link
Contributor

PR summary

I have added a datetime smoketest forAxes.hlines tolib/matplotlib/tests/test_datetime.py. This example is very similar toAxes.axhline (#27177) – but to test the entire functionality ofhlines, I have done a combination of datetime.datetime/np.datetime64 arrays with both scalar and arrayxmin/xmax arguments.

Below is an image of the plot generated from this example code.
test_hlines

This addresses theAxes.hlines task from#26864.

PR checklist

Copy link
Member

@ksundenksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we also wish to test thexmin/xmax as dates here

CozyFrog reacted with thumbs up emoji
@CozyFrog
Copy link
ContributorAuthor

Thank you for noting that, I did not think to checkxmin/xmax as dates here - I have updated this test to do so, both with singular datetime values and datetime arrays.

This is what the plot generated by this example code looks like:
hlines_datetime_xmin_max

@CozyFrog
Copy link
ContributorAuthor

I added singular float arguments for xmin/xmax - I think that might be why one of the CodeCov checks did not pass.

Here is what the new plot looks like:
hlines_increased_coverage

@CozyFrog
Copy link
ContributorAuthor

@ksunden@scottshambaugh could I please have some advice on why the codecov/project/tests check is not passing? It's at 98.76% "compared toa589856" - I don't know why it's comparing this to the test for scatter.

@CozyFrog
Copy link
ContributorAuthor

If anybody is having the same issue, I think it stemmed simply from the fact that my branch was not current with the main body of work. Synchronizing it fixed the issue.

@ksundenksunden mentioned this pull requestNov 15, 2023
64 tasks
@ksundenksunden merged commit02489d4 intomatplotlib:mainNov 21, 2023
@QuLogicQuLogic added this to thev3.9.0 milestoneNov 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ksundenksundenksunden approved these changes

@scottshambaughscottshambaughscottshambaugh approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

5 participants
@CozyFrog@ksunden@scottshambaugh@QuLogic@melissawm

[8]ページ先頭

©2009-2025 Movatter.jp