Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Improve legend picking example#27205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
* Pass an actual pickradius instead of `True`. `True` (`1`) is a baduser experience.* Fix `on_pick` to work when the legend is draggable. (Early exit)* For good measure, show that it works with draggable legends.* Use higher visability syntax for single element destrturing for higherreadability.* Refactor varible names. (`lined` -> `map_legend_to_ax`)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
Thank you@judfs and congratulations on your first merged Matplotlib PR 🎉 I hope we hear from you again. |
…205-on-v3.8.xBackport PR#27205 on branch v3.8.x (Improve legend picking example)
PR summary
True.True(1) is a bad user experience.on_pickto work when the legend is draggable. (Early exit)lined->map_legend_to_ax)Live version:https://matplotlib.org/stable/gallery/event_handling/legend_picking.html
PR checklist