Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Look for user-specified styles in ~/.config/matplotlib/stylelib#2720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Can you please clean up the PEP8 violations? It looks like you left some trailing white space on one of the lines. This changes looks reasonable to me, but I suspect that this should have a more correct handling of paths (does I see no reason not to merge this (once pep8 is fixed), but it is a stop-gap. |
|
| @@ -30,7 +30,8 @@ | |||
| _here = os.path.abspath(os.path.dirname(__file__)) | |||
| BASE_LIBRARY_PATH = os.path.join(_here, 'stylelib') | |||
| # Users may want multiple library paths, so store a list of paths. | |||
| USER_LIBRARY_PATHS = [os.path.join('~', '.matplotlib', 'stylelib')] | |||
| USER_LIBRARY_PATHS = [os.path.join('~', '.matplotlib', 'stylelib'), | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this would be better if it just usedmatplotlib._get_configdir() and then it can be configured in a consistent way.@tonysyu, did you have a motivation for not using that function in the first place, or was it just a case of it being well hidden?
Look for user-specified styles in ~/.config/matplotlib/stylelib
Hi all,
I just noticed that the
stylesmodule currently only looks for user-specified styles in~/.matplotlib/stylelib. I think it ought to also look in~/.config/matplotlib/stylelib/for consistency with~/.config/matplotlib/matplotlibrcand in order to comply with thelatest XDG standard (c.f.#454).