NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Smoke Test for Axes.step#27162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

0taj wants to merge3 commits intomatplotlib:mainfrom0taj:test_fill

Closed

Smoke Test for Axes.step#27162

0taj wants to merge3 commits intomatplotlib:mainfrom0taj:test_fill

Conversation

Copy link

Contributor

0taj commentedOct 21, 2023•
edited
Loading

PR summary

Smoke test for Axes.step using datetime data in lib/matplotlib/tests/test_datetime.py. This PR addresses one of the tasks listed in#26864

The image displays the plot of the test case:

PR checklist

"closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
[N/A ]Plotting related features are demonstrated in anexample
[N/A]New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

Added smoke test for Axes.step

fc8791d

ksunden mentioned this pull request

Oct 23, 2023

[TST]: increase unit test coverage#26864

Open

64 tasks

0taj force-pushed thetest_fill branch fromf905f04 tofc8791dCompare

October 24, 2023 00:16

0taj added2 commits

October 23, 2023 20:18

Fix for underindentation

3dd8da1

Changed variable names

2982f5e

ksunden approved these changes

Oct 24, 2023

View reviewed changes

Copy link

Member

ksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could be simplified a bit, but it is largely fine:

Usenp.arange instead ofnp.array(range(...))
Could even usenp.arange for the dates e.g.:

np.arange(start_date,start_date+datetime.timedelta(weeks=1),datetime.timedelta(days=1))

Does work

Also the last axes using the data arg I don't think really needs to be tested here, its notwrong, but it is testing a broader functionality that is largely orthogonal.

Copy link

Contributor

scottshambaugh commentedOct 24, 2023

Hi@0taj thank you for your contribution! Unfortunately it looks like#27091 also implemented this test and was opened as a PR first, so I'm closing this one as a duplicate. However I would encourage you to pick out another of the functions from the list in#26864 and take a shot at it!