NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

added test_axhspan in test_datetime.py#27139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ksunden merged 3 commits intomatplotlib:mainfromdanielcobej:add_test_axhspan

Oct 20, 2023

Merged

added test_axhspan in test_datetime.py#27139

ksunden merged 3 commits intomatplotlib:mainfromdanielcobej:add_test_axhspan

Oct 20, 2023

Conversation

Copy link

Contributor

danielcobej commentedOct 18, 2023•
edited
Loading

I´ve added code fortest_axhspan method intest_datetime.py mentioned in issue#26864

Image output: (edited)

PR summary

PR checklist

resolves#26864
new and changed code istested
Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

added test_axhspan

994abce

melissawm added the topic: testing label

Oct 18, 2023

ksunden requested changes

Oct 18, 2023

View reviewed changes

Copy link

Member

ksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Neither of the axes have units on the y axis, which is the one that matters foraxhspan. As such, no datetime values are being passed to the function we are trying to test.

switched x and y axis

42c4ef0

Copy link

ContributorAuthor

danielcobej commentedOct 18, 2023

Neither of the axes have units on the y axis, which is the one that matters foraxhspan. As such, no datetime values are being passed to the function we are trying to test.

Sorry, it should be fixed now.