NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Added smoke test for Axes.stem#27135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

QuLogic merged 7 commits intomatplotlib:mainfrom0taj:test_case

Dec 5, 2023

Merged

Added smoke test for Axes.stem#27135

QuLogic merged 7 commits intomatplotlib:mainfrom0taj:test_case

Dec 5, 2023

Conversation

Copy link

Contributor

0taj commentedOct 18, 2023•
edited
Loading

PR summary

Smoke test forAxes.stem using datetime data inlib/matplotlib/tests/test_datetime.py. This PR addresses one of the tasks listed in#26864

The image displays the plot of the test case:

PR checklist

"closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

Added smoke test for Axes.stem

b9db8ab

Copy link

ContributorAuthor

0taj commentedOct 18, 2023

I see that I need to reformat the code, but I was wondering if the test case handles the required task as this is one of my first PRs

melissawm added the topic: testing label

Oct 18, 2023

ksunden requested changes

Oct 18, 2023

View reviewed changes

Copy link

Member

ksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add abottom argument to avoid the implicit 1970-01-01 of this method (and exercise that part of the code) (There is also achance this is broken already, so if it is, that should be reported)

Also please test both vertical and horizontal orientations, as we want to make sure we don't miss that from this method.

Copy link

Member

QuLogic commentedOct 18, 2023

Probably should set some of the dates to be belowbottom as well.

Updates to include bottom and orientation

83ce6c3

Copy link

ContributorAuthor

0taj commentedOct 19, 2023•
edited
Loading

Here is also the updated figure. Sorry if there are still some mistakes but if there are any other changes that need to be made I will make those as well!