NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

added test_axvspan in test.datetime.py#27130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

scottshambaugh merged 3 commits intomatplotlib:mainfromdanielcobej:add_axvspan

Oct 24, 2023

Merged

added test_axvspan in test.datetime.py#27130

scottshambaugh merged 3 commits intomatplotlib:mainfromdanielcobej:add_axvspan

Oct 24, 2023

Conversation

Copy link

Contributor

danielcobej commentedOct 18, 2023•
edited
Loading

I´ve added code fortest_axvspan method intest_datetime.py mentioned in issue#26864

Image output: (edited)

PR summary

PR checklist

resolves#26864
new and changed code istested
Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

added test_axvspan

2d70e18

melissawm added the topic: testing label

Oct 18, 2023

github-actionsbot reviewed

Oct 18, 2023

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

ksunden reviewed

Oct 18, 2023

View reviewed changes

Copy link

Member

ksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you set the random seed so that we get a reproducible result?

(We aren't doing an image test here (yet) but we are likely to make it one at some point, and just having non reproducible test cases can make tracking things down all that much harder)

https://matplotlib.org/stable/devel/testing.html#random-data-in-tests

added random seed number

eb0ff88

Copy link

ContributorAuthor

danielcobej commentedOct 18, 2023

Can you set the random seed so that we get a reproducible result?
(We aren't doing an image test here (yet) but we are likely to make it one at some point, and just having non reproducible test cases can make tracking things down all that much harder)
https://matplotlib.org/stable/devel/testing.html#random-data-in-tests

I've added seed number19680801