The task i am working with isAxe.pie problem from the issue#26864 . TheAxe.pie should be removed from the filetest_datetime.py file because we cannot directly pass thedatetime object intopie as a parameter to perform any of the plots. The error message below shows the case occured whendatetime object is directly passed into thepie function:

PR checklist

[N/A] "closes #0000" is in the body of the PR description tolink the related issue
[N/A] new and changed code istested
[N/A]Plotting related features are demonstrated in anexample
[N/A]New Features andAPI Changes are noted with adirective and release note
[N/A] Documentation complies withgeneral anddocstring guidelines

u7277320 added3 commits

October 17, 2023 14:50

Added the smoke testing for pie function

50608b4

Fixed some typos and mistakes in test code.

b6b9378

added further comments

91d2ecc

Copy link

ContributorAuthor

Sheepfan0828 commentedOct 17, 2023

Both u7277320 and sheepfan0828 are my personal Github account

github-actionsbot reviewed

Oct 17, 2023

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Copy link

ContributorAuthor

Sheepfan0828 commentedOct 17, 2023

Is it okey that some checks are not passed?

Copy link

Member

ksunden commentedOct 17, 2023

The linting would need to be addressed.

However, more fundamentally, this is not exercising the datetime unit machinery that is expected here, and in factpie in general does not use the units system (and it's unclear what it evenwould mean).

As such I thinkpie should just be removed from this file all together (much like we did to table/spectral methods in#27072)

The list from the original issue/stubs was intentionally a bit broad but part of the idea was to evaluate whether it was using units at all. In this case it is not, and so it should just be removed.

Copy link

ContributorAuthor

Sheepfan0828 commentedOct 17, 2023•
edited
Loading

@ksunden Sorry, what do you mean by that? I cannot understand, can you please explain it more specific?

Copy link

Member

ksunden commentedOct 17, 2023

This method falls into the category that passing datetimes to it directly does not make sense and therefore should just be removed (From#26864):

iii: If passing datetime / united data to the method does not make any sense or it should not work open a PR removing that test method and similarly reference this issue.

By callingto_ordinal here, you are not passing the datetime objects, and so are not doing what this test file is trying to exercise. This is because the idea of this test file does not make sense forpie, and therefore the xfail stub (the entire method) should just be removed altogether.

Copy link

ContributorAuthor

Sheepfan0828 commentedOct 17, 2023

This method falls into the category that passing datetimes to it directly does not make sense and therefore should just be removed (From#26864):
iii: If passing datetime / united data to the method does not make any sense or it should not work open a PR removing that test method and similarly reference this issue.
By callingto_ordinal here, you are not passing the datetime objects, and so are not doing what this test file is trying to exercise. This is because the idea of this test file does not make sense forpie, and therefore the xfail stub (the entire method) should just be removed altogether.

So do you mean that is the method that i am testing with (pie this case) is not accepting datetime object so that the testing function forpie should be removed from the file? If so, i need to remove it fromtest_datetime.py right now and then create another pull request that i have removed thepie. Is that right?