Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Final remove#27092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Final remove#27092
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…atplotlib/gridspec.py and lib/matplotlib/_fontconfig_patterns.py
…atplotlib/gridspec.py and lib/matplotlib/_fontconfig_patterns.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for your contribution@Krrish2512!
Thegridspec lines you removed are not actually deprecations, and the deprecations that were in that file were handled at#26885.
| "3.7", message=f"Support for unknown constants " | ||
| f"({prop[0]!r}) is deprecated since %(since)s and " | ||
| f"will be removed %(removal)s.") | ||
| continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should now raise an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Too much code is removed, as noted by@rcomer.
I’m going to close this as#26865 is complete. |
PR summary
This PR removes the deprecated code during the version 3.7 from lib/matplotlib/gridspec.py and lib/matplotlib/_fontconfig_patterns.py
-->
PR checklist