Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
MNT: revert contour deprecations#27075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
9ec3c40
to60dc1f7
Compare60dc1f7
tod68f01a
Compared68f01a
to536582f
CompareFor find_nearest_contour that won't really work, as you'd also need to undeprecate the collections property, which is accessed by its implementation (as detailed in#27070 (comment)), and then you'd need to decide whether accessing that property just permanently triggers the conversion to the old-style internal representation or not (currently it does as that's the point of the backcompat layer). If it does then that means that any ContourSet on which one calls find_nearest_contour will revert back to a state where#6139,#11464,#23080 are broken. Perhaps we should keep that discussion at#27070 though. I can't say Ilike keeping allsegs and allkinds around forever, but I don't really mind either. |
I have pulled this change into#27088. |
Uh oh!
There was an error while loading.Please reload this page.
contour.allsegs
,contour.allkinds
, andcontour.find_nearest_contour
are no longer marked for deprecation.These are useful for post-processing and perhaps extra labelling. It pins us down a bit more to have them available, but the benefit justifies the cost in my opinion.
Closes#27070#26913