Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

MNT: revert contour deprecations#27075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

jklymak
Copy link
Member

@jklymakjklymak commentedOct 12, 2023
edited
Loading

contour.allsegs,contour.allkinds, andcontour.find_nearest_contour are no longer marked for deprecation.

These are useful for post-processing and perhaps extra labelling. It pins us down a bit more to have them available, but the benefit justifies the cost in my opinion.

Closes#27070#26913

@jklymakjklymakforce-pushed themnt-revert-contour-deprecations branch from9ec3c40 to60dc1f7CompareOctober 12, 2023 22:01
@jklymakjklymak requested a review fromanntzerOctober 12, 2023 22:03
@jklymakjklymak marked this pull request as ready for reviewOctober 12, 2023 22:03
@jklymakjklymakforce-pushed themnt-revert-contour-deprecations branch from60dc1f7 tod68f01aCompareOctober 12, 2023 22:04
@jklymakjklymakforce-pushed themnt-revert-contour-deprecations branch fromd68f01a to536582fCompareOctober 12, 2023 22:05
@anntzer
Copy link
Contributor

For find_nearest_contour that won't really work, as you'd also need to undeprecate the collections property, which is accessed by its implementation (as detailed in#27070 (comment)), and then you'd need to decide whether accessing that property just permanently triggers the conversion to the old-style internal representation or not (currently it does as that's the point of the backcompat layer). If it does then that means that any ContourSet on which one calls find_nearest_contour will revert back to a state where#6139,#11464,#23080 are broken. Perhaps we should keep that discussion at#27070 though.

I can't say Ilike keeping allsegs and allkinds around forever, but I don't really mind either.

@jklymak
Copy link
MemberAuthor

@anntzer apologies - I didn't see your note on#27070. Lets move this to draft and discuss that first...

@jklymakjklymak marked this pull request as draftOctober 12, 2023 22:59
@rcomer
Copy link
Member

I have pulled this change into#27088.

jklymak reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzerAwaiting requested review from anntzer

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: find_nearest_contour deprecated with no replacement?
4 participants
@jklymak@anntzer@rcomer@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp