Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add datetime testing for boxplot#27038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ayushrathore111 wants to merge2 commits intomatplotlib:main
base:main
Choose a base branch
Loading
fromayushrathore111:main

Conversation

ayushrathore111
Copy link

@ayushrathore111ayushrathore111 commentedOct 9, 2023
edited by ksunden
Loading

PR summary

I have added the code corresponding screenshots for the boxplot testing function in test_datetime.py file. and completed the portion for Axes.boxplot of issue#26864"
this is the screenshot of boxplot by given code..
boxplot_final

-->

PR checklist

Copy link
Member

@ksundenksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We'd prefer to use the axes interface over theplt methods for this test.

Also I'd like to see another axes that shows avert=False boxplot to make sure that the unit handling works for horizontal boxplots.

Could also argue forpositions to be given as datetimes (in another plot...) to make sure that it handles that as well.

Comment on lines +97 to +98
datums = np.array([datetime.datetime.toordinal(d) for d in data])
plt.boxplot(datums, labels=['my data'], showfliers=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
datums=np.array([datetime.datetime.toordinal(d)fordindata])
plt.boxplot(datums,labels=['my data'],showfliers=True)
plt.boxplot(data,labels=['my data'],showfliers=True)

We actually very specificallywant the datetimes passed into the plotting methods here. as it stands, this test is not actually testing the unit conversion at all.

@shriyakalakata
Copy link
Contributor

Since this PR has been inactive for over two months, can I create a new PR using advice from the comment on#27485 :

"I think it could translate well to physical units, so perhaps we should make it so that at least we try to adhere to the units behavior..."

@ksundenksunden mentioned this pull requestDec 12, 2023
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ksundenksundenksunden requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Projects
Status: Needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@ayushrathore111@shriyakalakata@ksunden@melissawm

[8]ページ先頭

©2009-2025 Movatter.jp