Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add test_plot_date in test_datetime.py#27037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

kots14
Copy link
Contributor

PR summary

Adding code fortest_plot_date method intest_datetime.py mentioned in#26864

Image output -
test_plot_date_image

PR checklist

@melissawm
Copy link
Member

Hi@kots14, thanks for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

kots14 reacted with thumbs up emoji

Copy link
Member

@ksundenksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A bit of an odd one in that despite sounding like it is doing things with dates, with these inputs actually just amounts toplot (and is a discouraged method because of that)... But it works and I guess no harm in testing it like this.

(For reference, it only does anything beyondplot ifxdate=True orydate=True are passed, at which point it sets the units of the axis)

@kots14
Copy link
ContributorAuthor

A bit of an odd one in that despite sounding like it is doing things with dates, with these inputs actually just amounts toplot (and is a discouraged method because of that)... But it works and I guess no harm in testing it like this.

(For reference, it only does anything beyondplot ifxdate=True orydate=True are passed, at which point it sets the units of the axis)

Should I include additional tests to accommodate this in the same test? Please suggest.

@ksunden
Copy link
Member

I'd say this is fine for this test file. If anything, I think I'd move towards actually deprecating this method, as it's been soft-deprecated (i.e. discouraged in the docstring, but not warning at runtime) since 3.5.

The date plotting parts of this method are already tested intest_axes.py (as full image comparison tests, so even more rigorous than we are wanting here initially).

kots14 reacted with thumbs up emoji

@jklymakjklymak merged commit7ea11b7 intomatplotlib:mainOct 10, 2023
@QuLogicQuLogic added this to thev3.9.0 milestoneOct 11, 2023
@QuLogicQuLogic mentioned this pull requestOct 13, 2023
64 tasks
@kots14kots14 deleted the axes-plot_date-unit-test-for-issue-26864 branchOctober 14, 2023 14:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Projects
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

5 participants
@kots14@melissawm@ksunden@jklymak@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp