Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Add test_bar in test_datetime#27033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add test_bar in test_datetime#27033
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think the bar graphs with dates on the vertical (forbar, horizonatal forbarh) axis should be given a bit more care here. That there is an implicit0 mark, which results in1970-01-01 is not a particularly good representation of a bar plot.
I think that for this, there should be abottom argument specified as a datetime and then using atimedelta instead of adatetime for the heights, as indicated by thebardocstring
Here is some code I wrote for someone who had started working on this but never opened a PR:
importmatplotlib.pyplotaspltimportnumpyasnpfromdatetimeimportdatetime,timedeltaimportmatplotlibasmplmpl.rcParams["date.converter"]='concise'fig, (ax1,ax2)=plt.subplots(2,1,layout='constrained')price_date=np.array([datetime(2020,6,30),datetime(2020,7,22),datetime(2020,8,3),datetime(2020,9,14)],dtype=np.datetime64)price_close= [8800,2600,8500,7400]start_date=np.datetime64(datetime(2020,6,1))ax1.bar(price_date,price_close,width=np.timedelta64(4,"D"))ax2.bar(np.arange(4),price_date-start_date,bottom=start_date)
Note thestart_date andprice_date-start_date in this example.
Also, while in your example it is not a bad width, I may suggest also testing the |
Thanks for the suggestions. I'll modify the code and raise a revision. |
I'll be raising the revision in next 3 days. |
@ksunden I've raised a revision. Please review the changes. |
There still appear to be the implicit 1970 in the new version And it is very hard to see what is happening in especially the middle two plots (but also the top plot) as the widths overlap all of the bars. A single width is probably sufficient, we just mostly want to test it out that it handles the units as expected, so changing from the default is a good check. |
kots14 commentedOct 16, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Noted. |
@ksunden |
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I was confused by the image added in the post,which seemed to get rid of the date axis on the y axis of the bottom plot, but I actually do keep it when I run this code, see attached.
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Version 4:
Modified tests and raised a revision
Version 4 Image output -
Version 3:
Modified tests and raised a revision
Version 3 Image output -
Version 2:
Modified tests as perthis andthis
Version 2 Image output -
Version 1:
Adding code for
test_barmethod intest_datetime.pymentioned in#26864Version 1 Image output -
PR checklist