Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Added test_hist in test_datetime.py#27028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This seems good. However, can you also check that specifying the bin edges in datetime64 works?
Do you want me to do it in a new method or have datetime64 and datetime in the same method? |
Sorry I didn't note that you had tested datetime not datetime64. I think testing datetime as the bin edges should be fine. |
Is there any other things that I need to do for this PR to be merged? |
My original request still stands. Please also test with a list of datetimes as the bin edges in addition to testing bins=10. |
Test with a list of datetimes as the bin edges: |
Let me know if I am doing it right or if there are any other requirements. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks! Needs another reviewer, but looks great to me
Thank you, congrats on your merged PR, hope to hear from you again! |
PR summary
Added test_hist method in test_datetime.py as part of the#26859
PR checklist