Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add test_contour under test_datetime.py#27013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

kots14
Copy link
Contributor

@kots14kots14 commentedOct 6, 2023•
edited
Loading

PR summary

Attempting adding code fortest_contour method intest_datetime.py mentioned in#26864

Image output -
test_datetime_contour

PR checklist

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@kots14kots14 changed the titleAdd test_contour #26864Add test_contour under test_datetime.pyOct 6, 2023
@ksundenksunden added this to thev3.9.0 milestoneOct 6, 2023
Copy link
Member

@ksundenksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Having 6 instead of 3 plots is slightly unnecessary (Z does not actually go through units behavior, and both Z values are just floats anyway)

But it looks correct and is testing what we want to test here.

Thank you@kots14

kots14 reacted with thumbs up emoji
@kots14
Copy link
ContributorAuthor

@ksunden Thank you for your feedback and for approving the changes.
In order to get this PR merged, is there any further modification expected?

@kots14kots14 mentioned this pull requestOct 6, 2023
64 tasks
Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I suppose the extra 3 Axes could be removed if you're making updates.

@kots14
Copy link
ContributorAuthor

I suppose the extra 3 Axes could be removed if you're making updates.

You mean from these lines shall I remove 3?

ax1.contour(X_dates, Y_dates, Z_timestamps)ax2.contour(X_dates, Y_ranges, Z_timestamps)ax3.contour(X_ranges, Y_dates, Z_timestamps)bx1.contour(X_dates, Y_dates, Z_ranges)bx2.contour(X_dates, Y_ranges, Z_ranges)bx3.contour(X_ranges, Y_dates, Z_ranges)

@ksunden
Copy link
Member

The last three (and get rid of the variables that become unused as a result).

kots14 reacted with thumbs up emoji

@QuLogicQuLogic merged commit92cc8f5 intomatplotlib:mainDec 12, 2023
@QuLogic
Copy link
Member

Thanks@kots14! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

kots14 reacted with thumbs up emoji

@kots14kots14 deleted the axes-contour-unit-test-for-issue-26864 branchDecember 12, 2023 11:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@QuLogicQuLogicQuLogic approved these changes

@ksundenksundenAwaiting requested review from ksunden

Assignees
No one assigned
Projects
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

4 participants
@kots14@ksunden@QuLogic@melissawm
[8]ページ先頭
©2009-2025 Movatter.jp