Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
DOC: Fix resizing of animation examples#27006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
For example, this will cause the double pendulum history to skip points like: |
On resize, either `init_func` will be called, or if not defined, themain `func` with `i=0` is called. On animations that save a state, thelatter can cause weird glitching as the history will skip around.* For `bayes_update`, I fixed it by providing an `init_func`.* For `double_pendulum`, I fixed it by simplifying the trace line (since we have the entire history pre-computed.)
story645 approved these changesOct 5, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 6, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 6, 2023
ksunden added a commit that referenced this pull requestOct 6, 2023
…006-on-v3.8.xBackport PR#27006 on branch v3.8.x (DOC: Fix resizing of animation examples)
ksunden added a commit that referenced this pull requestOct 6, 2023
…006-on-v3.8.0-docBackport PR#27006 on branch v3.8.0-doc (DOC: Fix resizing of animation examples)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
On resize, either
init_funcwill be called, or if not defined, the mainfuncwithi=0is called. On animations that save a state, the latter can cause weird glitching as the history will skip around.bayes_update, I fixed it by providing aninit_func.double_pendulum, I fixed it by simplifying the trace line (since we have the entire history pre-computed.)PR checklist