This looks good, but it needs an API change note for the removals. There's also something insrc/_backend_agg_wrapper.cpp that's backend-related if you want to remove that too.

There's also something insrc/_backend_agg_wrapper.cpp that's backend-related if you want to remove that too.

I've removed the deprecated methodsPyBufferRegion_to_string andPyBufferRegion_to_string_argb fromsrc/_backend_agg_wrapper.cpp as suggested. The API change notes have been updated accordingly. Please review.

Doc build is failing because of the build system change, should be fixed by rebasing again onto currentupstream/main.

Also the changelog note wants a newline at the end (this is what is failing pre-commit CI)

hey can i work on this issue

This is not an open issue; it's an open pull request waiting for a reply from the original submitter,@issamarabi. There is no work to be done here unless the original submitter has disappeared (and it's not clear that enough time has passed for that to be the case).

@issamarabi please report back whether you are you planning to continue this work.

Sorry about that!

I created several commits to separate distinct changes. I think this will help future coders. I also wouldn't know how to create one commit message that encompasses all the changes I made.

I created several commits to separate distinct changes. I think this will help future coders. I also wouldn't know how to create one commit message that encompasses all the changes I made.

I think the PR title would be fine as a commit message, though you can also create a multi-line commit message if you want to add more detail. In general, Matplotlib tries to keep commits to a minimum and, while we are not overly strict about that, it would be very unusual for this project to merge 14 separate commits from a single PR.

Thanks@issamarabi! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.