Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ci: Run mypy against typed cycler#26943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 1 commit intomatplotlib:mainfromQuLogic:typed-cycler
Oct 11, 2023

Conversation

QuLogic
Copy link
Member

PR summary

This tests against the new cycler release candidate, and then drops the flag/comment noted in the ci config.

PR checklist

@QuLogicQuLogic added the CI: testingCI configuration and testing labelSep 28, 2023
@QuLogicQuLogic marked this pull request as ready for reviewSeptember 29, 2023 00:34
@QuLogic
Copy link
MemberAuthor

Un-drafted now that typed cycler is out.

@QuLogicQuLogic added this to thev3.8.1 milestoneSep 29, 2023
@ksunden
Copy link
Member

We have theignore_missing_imports=true inpyproject.toml, and removing that has revealed that cycler installed from pypi doesn't include thepy.typed sentinel file...

Which is somewhat odd becausematplotlib/cycler#88 specifically mentions that file (in the sdist)

I can confirm that building locally the file is not included...

@ksunden
Copy link
Member

I've openedmatplotlib/cycler#98 in response

@QuLogic
Copy link
MemberAuthor

OK, I've made a new cycler release with those changes included, and updatedpyproject.toml here as well.

@ksundenksunden merged commit6d5f286 intomatplotlib:mainOct 11, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 11, 2023
@QuLogicQuLogic deleted the typed-cycler branchOctober 11, 2023 20:10
story645 added a commit that referenced this pull requestOct 12, 2023
…943-on-v3.8.xBackport PR#26943 on branch v3.8.x (ci: Run mypy against typed cycler)
@ksundenksunden mentioned this pull requestNov 2, 2023
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@oscargusoscargusoscargus approved these changes

Assignees
No one assigned
Labels
CI: testingCI configuration and testingtopic: typing
Projects
None yet
Milestone
v3.8.1
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@ksunden@oscargus
[8]ページ先頭
©2009-2025 Movatter.jp