Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

deprecated api tri#26909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 10 commits intomatplotlib:mainfromvigneshvetrivel8:deprecated_api
Oct 2, 2023
Merged

Conversation

vigneshvetrivel8
Copy link
Contributor

@vigneshvetrivel8vigneshvetrivel8 commentedSep 25, 2023
edited by ksunden
Loading

PR summary

Helps with#26865 (lib/matplotlib/tri/*.py).

PR checklist

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@ksunden
Copy link
Member

The deprecation here is to remove the edited files entirely, as their contents/organization is now considered private (and thus they have_tri<x> python modules).

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is not removing the deprecations, but changing imports in files that are deprecated, which does not achieve the desired result. In fact, it causesmore things to appear in the deprecated files.

Copy link
Member

@ksundenksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please do not edit the 00001-ABC.rst file, and instead make a new file e.g.26909-VV.rst

You can copy the contents (and update to reflect removal instead of deprecation) from, which gives more context and says what to do instead:

``matplotlib.tri`` submodules are deprecated
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The ``matplotlib.tri.*`` submodules are deprecated. All functionality is
available in ``matplotlib.tri`` directly and should be imported from there.

@vigneshvetrivel8vigneshvetrivel8force-pushed thedeprecated_api branch 2 times, most recently fromddc5bdb tod89567aCompareSeptember 29, 2023 04:51
@QuLogicQuLogic mentioned this pull requestSep 29, 2023
5 tasks
@vigneshvetrivel8
Copy link
ContributorAuthor

Do i need to modify some more or is this enough. Is this PR ok.

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good, except for the pre-commit linting issue. I'm going to have it fix it automatically for you.

@QuLogic
Copy link
Member

pre-commit.ci autofix

pre-commit-ci[bot] reacted with rocket emoji

@ksundenksunden self-requested a reviewOctober 2, 2023 21:07
@ksundenksunden added this to thev3.9.0 milestoneOct 2, 2023
@ksundenksunden merged commit5bf7e33 intomatplotlib:mainOct 2, 2023
@QuLogic
Copy link
Member

Thanks@vigneshvetrivel8! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

issamarabi pushed a commit to issamarabi/matplotlib that referenced this pull requestOct 5, 2023
* deprecated api tri* updated deprecated api tri* updated deprecated api tri* updated deprecated api tri* updated deprecated api tri* pre-commit.ci autofix* [pre-commit.ci] auto fixes from pre-commit.com hooksfor more information, seehttps://pre-commit.ci---------Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@QuLogicQuLogicQuLogic approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

3 participants
@vigneshvetrivel8@ksunden@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp