Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
deprecated api tri#26909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
deprecated api tri#26909
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
ksunden commentedSep 25, 2023
The deprecation here is to remove the edited files entirely, as their contents/organization is now considered private (and thus they have |
QuLogic left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is not removing the deprecations, but changing imports in files that are deprecated, which does not achieve the desired result. In fact, it causesmore things to appear in the deprecated files.
ksunden left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please do not edit the 00001-ABC.rst file, and instead make a new file e.g.26909-VV.rst
You can copy the contents (and update to reflect removal instead of deprecation) from, which gives more context and says what to do instead:
| ``matplotlib.tri`` submodules are deprecated | |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |
| The ``matplotlib.tri.*`` submodules are deprecated. All functionality is | |
| available in ``matplotlib.tri`` directly and should be imported from there. | |
70e81c7 to780bb45CompareUh oh!
There was an error while loading.Please reload this page.
ddc5bdb tod89567aComparevigneshvetrivel8 commentedSep 29, 2023
Do i need to modify some more or is this enough. Is this PR ok. |
QuLogic left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks good, except for the pre-commit linting issue. I'm going to have it fix it automatically for you.
QuLogic commentedSep 30, 2023
pre-commit.ci autofix |
for more information, seehttps://pre-commit.ci
QuLogic commentedOct 3, 2023
Thanks@vigneshvetrivel8! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
* deprecated api tri* updated deprecated api tri* updated deprecated api tri* updated deprecated api tri* updated deprecated api tri* pre-commit.ci autofix* [pre-commit.ci] auto fixes from pre-commit.com hooksfor more information, seehttps://pre-commit.ci---------Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Helps with#26865 (lib/matplotlib/tri/*.py).
PR checklist