Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fixed deprecated APIs in lines.py#26902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
While working on your suggestions, I tried to update my codebase and squash my commits to 1 but it resulted in a merge conflict which I could not resolve. Therefore, I created a new PR. I hope that's ok. |
@rsp2210 I would highly recommend not working on Can you rename the file to reflect the PR number (looks like an issue came in that snagged the number you put)? Also add a blank line to the end of the release note file to make pre-commit CI happy. |
| @@ -0,0 +1,4 @@ | |||
| ``set_xdata`` and ``set_ydata`` requires an iterable. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should mentionLine2D. Feel free to copy from the original deprecation release note:
matplotlib/doc/api/prev_api_changes/api_changes_3.7.0/deprecations.rst
Lines 287 to 291 in6028039
| ``Line2D`` | |
| ~~~~~~~~~~ | |
| When creating a Line2D or using `.Line2D.set_xdata` and `.Line2D.set_ydata`, | |
| passing x/y data as non sequence is deprecated. |
I'll keep this in mind. Thanks for the guidance. |
| ~~~~~~~~~~ | ||
| When creating a Line2D or using `.Line2D.set_xdata` and `.Line2D.set_ydata`, | ||
| passing x/y data as non sequence is deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| passing x/y data as non sequence isdeprecated. | |
| passing x/y data as non sequence isnow an error. |
Do you feel comfortable squashing your commits down to avoid adding and deleting the same file? |
| ``Line2D`` | ||
| ~~~~~~~~~~ | ||
| When creating a Line2D or using `.Line2D.set_xdata` and `.Line2D.set_ydata`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| ``Line2D`` | |
| ~~~~~~~~~~ | |
| When creating a Line2D or using `.Line2D.set_xdata` and `.Line2D.set_ydata`, | |
| ``Line2D`` | |
| ~~~~~~~~~~ | |
| When creating a Line2D or using `.Line2D.set_xdata` and `.Line2D.set_ydata`, |
Trailing whitespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM other than the trailing whitespace and squashing.
I addressed the white space issue and followed the standard approach of squashing but it somehow increased the commits |
It appears you rebased commits from |
a2ebfdd to440cb1eCompareLooks like the changes got lost in the rebase/sync with main, which made it so there are no commits here and this got closed... |
Yes, I'm trying to resolve the conflicts and I've never faced such issues before, learned much more about GitHub functionalities and good practices. I'll definitely keep in mind to not work on the main branch again, as this PR was made from the main branch I had no options but to reset and work on it to squash my commits. Therefore, I reopened it after applying changes. I really appreciate your patience with me. |
| ~~~~~~~~~~ | ||
| When creating a Line2D or using `.Line2D.set_xdata` and `.Line2D.set_ydata`, | ||
| passing x/y data as non sequence is now an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| passing x/y data as non sequence is now an error. | |
| passing x/y data as non sequence is now an error. | |
This should fix pre-commit ci, which is complaining about the end of the file here
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Fixed deprecated parts in set_xdata and set_ydata APIs in lines.py
PR checklist