Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
#26865 removing deprecations to axislines.py#26900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
acb4a7f to5044e8fCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
I think this is good, subject to updating the wording of the release note.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
For a second reviewer: there is a PR open for patches,#26890, but this can go in as is, the other requires some updates. |
We merged another PR that addressed the patches portions of this,@farrjere can you refocus this PR on only the axislines portion? |
lib/matplotlib/patches.pyi Outdated
| class _Base(ConnectionStyle): | ||
| @ api.deprecated("3.7") | ||
| class SimpleEvent: | ||
| def __init__(self, xy: tuple[float, float]) -> None: ... | ||
| def __init__(self, xy): | ||
| self.x, self.y = xy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We do not wish to add this back, especially as this is apyi stub file (where@api.deprecated has no effect)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please revert changes topatches.pyi
Needs a rebase because an adjacent bit of code was modified (adding a new deprecation for the 3.9 cycle). That deprecation should be kept, but the removal of the |
Wouldn't handling the merge conflict handle that? I went to do this myself but it resulted in an issue with _version.py having a formatting issue that couldn't commit (coming from the merge). |
Rebasing is our preferred method of handling merge conflicts.
The patch as submitted has additions to |
Thanks@farrjere! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
PR summary
This PR removes the depcrecated code during the version 3.7 from patches.py and axislines.py for the issue#26865
PR checklist