Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Add scatter test for datetime units#26882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
I incorporated the issues you mentioned in my 2nd commit. |
|
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| # rotate labels so they don't look clogged | ||
| for label in axs[0].get_xticklabels(): | ||
| label.set_rotation(40) | ||
| label.set_horizontalalignment('right') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
With a shorter array, this might not be necessary; would have to see what it looks like then.
|
I needed to rotate axis labels because they were still clogged after I reduced array length
| np.random.seed(19680801) | ||
| y = np.cumsum(np.random.randn(N)) | ||
| fig, axs = plt.subplots(3, 1, layout='constrained', figsize=(6, 6)) | ||
| lims = [(np.datetime64('2005-02'), np.datetime64('2005-04')), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It doesn't look like lims is used
Thank you for the contribution! I noted one thing to clean up but it looks generally good to me. A note for whoever merges this, it closes the "Axes.scatter" item of#26864, not the whole ticket. |
eliminated unused variable according to feedback ('lims')I deleted lims in my most recent pull request. Please review my request again. |
Thanks @seohyeon-lee-2025! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Closes issue#26864
added 3 subplots with datetime array on the x axis, y axis, and both axes.
PR checklist